Discussion:
[PATCH 3/5] staging: speakup: refactor spk_stop_serial_interrupt
Okash Khawaja
2017-02-08 22:51:15 UTC
Permalink
This moves the call to spk_stop_serial_interrupt() function into
release() method of respective synths.
Samuel Thibault
2017-02-08 23:04:37 UTC
Permalink
Post by Okash Khawaja
This moves the call to spk_stop_serial_interrupt() function into
release() method of respective synths.
Again, you need to say the "why": we don't want to hardcode calling
spk_stop_serial_interrupt() in synth_release(), and we don't actually
need to make it a method, making the release method call it is fine
enough.

Samuel
Okash Khawaja
2017-02-08 23:10:15 UTC
Permalink
On Wed, Feb 8, 2017 at 11:04 PM, Samuel Thibault
Post by Samuel Thibault
Post by Okash Khawaja
This moves the call to spk_stop_serial_interrupt() function into
release() method of respective synths.
Again, you need to say the "why": we don't want to hardcode calling
spk_stop_serial_interrupt() in synth_release(), and we don't actually
need to make it a method, making the release method call it is fine
enough.
spk_stop_serial_interrupt() is not a method. release method calls it.
I think that's what I have said in the description. I'll add the
reason why.
Post by Samuel Thibault
Samuel
Loading...