[PATCH] staging: speakup: fix warning for static declaration

[Okash Khawaja]

Hi Gustavo,

symbol 'spk_serial_out' was not declared. Should it be static?
---
drivers/staging/speakup/serialio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c
index 5e31aca..3fab1c3 100644
--- a/drivers/staging/speakup/serialio.c
+++ b/drivers/staging/speakup/serialio.c
@@ -243,7 +243,7 @@ unsigned char spk_serial_in_nowait(void)
}
EXPORT_SYMBOL_GPL(spk_serial_in_nowait);
-int spk_serial_out(struct spk_synth *in_synth, const char ch)
+static int spk_serial_out(struct spk_synth *in_synth, const char ch)
{
if (in_synth->alive && spk_wait_for_xmitr(in_synth)) {
outb_p(ch, speakup_info.port_tts);
--
2.5.0

Thanks for this :) Could you also move the function higher in the same
file - above line 139 where all static functions are defined?

Okash

[Samuel Thibault]

symbol 'spk_serial_out' was not declared. Should it be static?

Yes, indeed.

Reviewed-by: Samuel Thibault <***@ens-lyon.org>

Thanks

---
drivers/staging/speakup/serialio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c
index 5e31aca..3fab1c3 100644
--- a/drivers/staging/speakup/serialio.c
+++ b/drivers/staging/speakup/serialio.c
@@ -243,7 +243,7 @@ unsigned char spk_serial_in_nowait(void)
}
EXPORT_SYMBOL_GPL(spk_serial_in_nowait);
-int spk_serial_out(struct spk_synth *in_synth, const char ch)
+static int spk_serial_out(struct spk_synth *in_synth, const char ch)
{
if (in_synth->alive && spk_wait_for_xmitr(in_synth)) {
outb_p(ch, speakup_info.port_tts);
--
2.5.0

[Samuel Thibault]

Post by Okash Khawaja
Thanks for this :) Could you also move the function higher in the same
file - above line 139 where all static functions are defined?

I'd say no need for this. spk_serial_in is just above. Moving functions
just for the sake of static vs non-static does not make the code more
readable to my eyes :)
(and it makes tracking changes harder in git annotate)

Samuel

[Okash Khawaja]

Post by Samuel Thibault

Post by Okash Khawaja
Thanks for this :) Could you also move the function higher in the same
file - above line 139 where all static functions are defined?

I'd say no need for this. spk_serial_in is just above. Moving functions
just for the sake of static vs non-static does not make the code more
readable to my eyes :)
(and it makes tracking changes harder in git annotate)
Samuel

Fair enough. When I marked it as static and moved it higher, I
misinterpreted your comment as we neither want it static nor moved. You
probably meant the latter :)