[PATCH] Staging: speakup: Fix allyesconfig build on mn10300

[Samuel Thibault]

mn10300 uses an mmio-driven uart. This is not supported by speakup, so
prevent from enabling it.

Signed-off-by: Samuel Thibault <***@ens-lyon.org>

--- a/drivers/staging/speakup/Kconfig
+++ b/drivers/staging/speakup/Kconfig
@@ -1,7 +1,7 @@
menu "Speakup console speech"

config SPEAKUP
- depends on VT
+ depends on VT && !MN10300
tristate "Speakup core"
---help---
This is the Speakup screen reader. Think of it as a

[Samuel Thibault]

On Mon, Feb 1, 2016 at 9:06 AM, Samuel Thibault

Post by Samuel Thibault
mn10300 uses an mmio-driven uart. This is not supported by speakup, so
prevent from enabling it.

Just wondering, what are the symptoms of the failure?

It'll try to request the 0x00-0x08 ports and fail, returning -ENODEV.

Is it a compile-time or run-time failure?

The fix is for compile-time. run-time failure will already return
-ENODEV.

Is this about drivers/staging/speakup/serialio.c?

Yes.

This code is to be replaced anyway.

Samuel

[Samuel Thibault]

I guess there are many other platforms where the UART is MMIO-driven...

Actually they can't ever get to be exposed to speakup's serialio.c:
their SERIAL_PORT_DFNS would set SERIAL_IO_MEM in the io_type field,
but that field doesn't even exist in serialio.c's old_serial_port, so
serialio.c would actually not even build, so we are on the safe side.

Samuel