Code style fixes for speakup kernel driver

[Aleksei]

Hi all.

I'm working on euduplula challenge (It is a series of programming
exercises for amateur linux kernel developers). As an exercise i
decided to improve driver for speakup. First I'm going to fix checkpatch
warnings in driver.

In attachment you can find a patch that fixes two types of warning:
WARNING: Block comments use a trailing */ on a separate line
WARNING: Block comments use * on subsequent lines

I hope with your guidance i can improve speakup driver a bit.

Sincerely yours, Aleksey.

P.S. I'm not sure if I'm writing to a correct mailing list. If i'm
mistaken, could you please point me a correct mail list for discussion
about speakup driver.

[Tony Baechler]

Hi,

Yes, this is the correct list for Speakup development. Someone can correct
me on this, but I don't think any major changes have been done to Speakup in
years. One thing which would be really helpful is if you could please find
a way to get serial synthesizers to work in kernels after 2.6.32 without
locking up the machine. On both 3.19 and 4.0, loading the speakup_dectlk
module locks up the system every time. Apparently there are ways to fix
this, but they also involve patches and it would be better if the patches
were not necessary. I am not a programmer, but I don't think this would be
too hard to fix. Others can post on the specific code changes or you can
search the Speakup list archives. Your help with this would be very
appreciated.

Post by Aleksei
I'm working on euduplula challenge (It is a series of programming
exercises for amateur linux kernel developers). As an exercise i
decided to improve driver for speakup. First I'm going to fix checkpatch
warnings in driver.
WARNING: Block comments use a trailing */ on a separate line
WARNING: Block comments use * on subsequent lines
I hope with your guidance i can improve speakup driver a bit.

[Chris Brannon]

Post by Aleksei
Hi all.
WARNING: Block comments use a trailing */ on a separate line
WARNING: Block comments use * on subsequent lines

Hi Aleksei,
Your patch looks fine to me. I found one change you probably need to
make, but I'll point it out at the end of the message, since it's minor.
Anyway, glad to hear of your interest in Speakup!
I'm glad to help with any pointers I can give, but my knowledge of the
code base is very stale at this point.

Post by Aleksei
P.S. I'm not sure if I'm writing to a correct mailing list. If i'm
mistaken, could you please point me a correct mail list for discussion
about speakup driver.

Yes, this is the correct list for discussions of Speakup. However,
Speakup is now in staging, so any patches need to go to another mailing
list where staging drivers are developed. The homepage for that list
can be found at:
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
I don't know what will happen if you Cc your patch to both the staging
list and this one. Hopefully it would go to both lists, but I guess it
depends on mailman configuration. Also the Speakup list does not allow
posts from non-subscribers.

Post by Aleksei
diff --git a/drivers/staging/speakup/speakup_acnt.h b/drivers/staging/speakup/speakup_acnt.h
index 6376fca..5858ffe 100644
--- a/drivers/staging/speakup/speakup_acnt.h
+++ b/drivers/staging/speakup/speakup_acnt.h
@@ -6,10 +6,12 @@
/* Port Status Flags */
#define SYNTH_READABLE 0x01 /* mask for bit which is nonzero if a
- byte can be read from the data port */
+ * byte can be read from the data port
+ */

Looks like you need a space between the final tab and the * in the last
line here.

Regards,
-- Chris