[patch 0/8] staging: speakup: introduce tty-based comms

[o***@gmail.com]

Hi,

This patchset introduces a TTY-based way for the synths to communicate
with devices as an alternate for direct serial comms used by the synths
at the moment. It then migrates some of the synths to the TTY-based
comms. Synths migrated in this patchset are dummy, acntsa, bns and
txprt.

The last patch also migrates ltlk with some temporary modification which
means that initial info from synth won't be retried. This shouldn't affect
normal functionality of the synth. We won't be sending lkml migration
to LKML, however it will be good to test it here.

I have also added the "TODO: support more than ttyS*" next to MKDEV line in
spk_ttyio.c, which was discussed last time but I hadn't put in.

Finally, please note that these apply cleanly on top of the latest staging
tree, which includes unicode changes recently merged.

Thanks,
Okash

[Okash Khawaja]

Couple of typos corrected below..

Post by o***@gmail.com
Hi,
This patchset introduces a TTY-based way for the synths to communicate
with devices as an alternate for direct serial comms used by the synths
at the moment. It then migrates some of the synths to the TTY-based
comms. Synths migrated in this patchset are dummy, acntsa, bns and
txprt.
The last patch also migrates ltlk with some temporary modification which
means that initial info from synth won't be retried. This shouldn't affect

means that initial info from synth won't be retrieved**.

Post by o***@gmail.com
normal functionality of the synth. We won't be sending lkml migration

We won't be sending ltlk** migration

Post by o***@gmail.com
to LKML, however it will be good to test it here.
I have also added the "TODO: support more than ttyS*" next to MKDEV line in
spk_ttyio.c, which was discussed last time but I hadn't put in.
Finally, please note that these apply cleanly on top of the latest staging
tree, which includes unicode changes recently merged.
Thanks,
Okash

[Samuel Thibault]

Hello,

Post by o***@gmail.com
This patchset introduces a TTY-based way for the synths to communicate
with devices

Ok, this looks good to me. Now you need to submit it. The
./scripts/get_maintainer.pl script applied to the various patches gives
the following list of recipients:

For the tty stuff:

Greg Kroah-Hartman <***@linuxfoundation.org> (supporter:TTY LAYER)
Jiri Slaby <***@suse.com> (supporter:TTY LAYER)
linux-***@vger.kernel.org (open list)

For the speakup stuff:

William Hubbs <***@gmail.com> (odd fixer:STAGING - SPEAKUP CONSOLE SPEECH DRIVER)
Chris Brannon <***@the-brannons.com> (odd fixer:STAGING - SPEAKUP CONSOLE SPEECH DRIVER)
Kirk Reiser <***@reisers.ca> (odd fixer:STAGING - SPEAKUP CONSOLE SPEECH DRIVER)
Samuel Thibault <***@ens-lyon.org> (odd fixer:STAGING - SPEAKUP CONSOLE SPEECH DRIVER)
Greg Kroah-Hartman <***@linuxfoundation.org> (supporter:STAGING SUBSYSTEM)
***@linux-speakup.org (open list:STAGING - SPEAKUP CONSOLE SPEECH DRIVER)
***@driverdev.osuosl.org (open list:STAGING SUBSYSTEM)

That looks reasonable to me, give these as Cc to quilt, and Greg & Jiri
as To to catch their attention.

About the non-threaded thing, I believe that's because you didn't use
the --reply-to option. So the idea would be to prepare your quilt
command, then write your "patch 0/7" mail, and once you have posted it,
pass the Message-Id to the --reply-to parameter of your quilt command.

In your "patch 0/7" mail, mention that this patch series is meant to
open the discussion about the changes proposed in patch 1 and how they
are used in patch 6.

Thanks!
Samuel

[Okash Khawaja]

On Sun, Mar 12, 2017 at 12:42 PM, Samuel Thibault

Post by Samuel Thibault
Hello,

Post by o***@gmail.com
This patchset introduces a TTY-based way for the synths to communicate
with devices

Ok, this looks good to me. Now you need to submit it. The
./scripts/get_maintainer.pl script applied to the various patches gives

Thanks! I'll also cc Alan Cox for the first patch, as you suggested earlier.

Post by Samuel Thibault
That looks reasonable to me, give these as Cc to quilt, and Greg & Jiri
as To to catch their attention.
About the non-threaded thing, I believe that's because you didn't use
the --reply-to option.

Yes, I didn't use --reply-to but according to /usr/share/doc/quilt/README.MAIL:

"Each message is assigned a unique Message-Id header, and all messages
other than the introduction are made to refer to the introduction (using
a References header) for proper message threading in mail clients."

Post by Samuel Thibault
So the idea would be to prepare your quilt
command, then write your "patch 0/7" mail, and once you have posted it,
pass the Message-Id to the --reply-to parameter of your quilt command.

For --reply-to we need to pass in the file containing the introduction email?

Thanks,
Okash

[Samuel Thibault]

Post by Okash Khawaja
On Sun, Mar 12, 2017 at 12:42 PM, Samuel Thibault

Post by Samuel Thibault

Post by o***@gmail.com
This patchset introduces a TTY-based way for the synths to communicate
with devices

Ok, this looks good to me. Now you need to submit it. The
./scripts/get_maintainer.pl script applied to the various patches gives

Thanks! I'll also cc Alan Cox for the first patch, as you suggested earlier.

Oh, right, he needs to be in the loop indeed.

Post by Okash Khawaja
"Each message is assigned a unique Message-Id header, and all messages
other than the introduction are made to refer to the introduction (using
a References header) for proper message threading in mail clients."

Ok, so it should have worked.

Post by Okash Khawaja

Post by Samuel Thibault
So the idea would be to prepare your quilt
command, then write your "patch 0/7" mail, and once you have posted it,
pass the Message-Id to the --reply-to parameter of your quilt command.

For --reply-to we need to pass in the file containing the introduction email?

I guess when using --reply-to one shouldn't provide an introduction text
at all, that'd be spurious.

Samuel

[Okash Khawaja]

On Mon, Mar 13, 2017 at 8:43 AM, Samuel Thibault

Post by Samuel Thibault

Post by Okash Khawaja
On Sun, Mar 12, 2017 at 12:42 PM, Samuel Thibault

Post by Samuel Thibault

Post by o***@gmail.com
This patchset introduces a TTY-based way for the synths to communicate
with devices

Ok, this looks good to me. Now you need to submit it. The
./scripts/get_maintainer.pl script applied to the various patches gives

Thanks! I'll also cc Alan Cox for the first patch, as you suggested earlier.

Oh, right, he needs to be in the loop indeed.

Post by Okash Khawaja
"Each message is assigned a unique Message-Id header, and all messages
other than the introduction are made to refer to the introduction (using
a References header) for proper message threading in mail clients."

Ok, so it should have worked.

Post by Okash Khawaja

Post by Samuel Thibault
So the idea would be to prepare your quilt
command, then write your "patch 0/7" mail, and once you have posted it,
pass the Message-Id to the --reply-to parameter of your quilt command.

For --reply-to we need to pass in the file containing the introduction email?

I guess when using --reply-to one shouldn't provide an introduction text
at all, that'd be spurious.

Of course. I mean the 0/7 email from sent folder.

But I should be able to work it out myself :)

[John Covici]

The one thing that will not work under these patches is indexing,
which I use all the time, so I hope you can integrate that soon. I
use the speakout synth.

On Sun, 12 Mar 2017 08:16:44 -0400,

Post by o***@gmail.com
Hi,
This patchset introduces a TTY-based way for the synths to communicate
with devices as an alternate for direct serial comms used by the synths
at the moment. It then migrates some of the synths to the TTY-based
comms. Synths migrated in this patchset are dummy, acntsa, bns and
txprt.
The last patch also migrates ltlk with some temporary modification which
means that initial info from synth won't be retried. This shouldn't affect
normal functionality of the synth. We won't be sending lkml migration
to LKML, however it will be good to test it here.
I have also added the "TODO: support more than ttyS*" next to MKDEV line in
spk_ttyio.c, which was discussed last time but I hadn't put in.
Finally, please note that these apply cleanly on top of the latest staging
tree, which includes unicode changes recently merged.
Thanks,
Okash
_______________________________________________
Speakup mailing list
http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup

[Samuel Thibault]

Post by John Covici
The one thing that will not work under these patches is indexing,

Sure, we know :)

We just start the TTY ball rolling with output for now, while we work on
input (which will not pose more questions from linux maintainers) :)

Samuel